Re: [PATCH] staging: prism2mgmt: Fixed a parentheses coding style

From: Greg KH
Date: Wed Jan 17 2024 - 00:48:06 EST


On Wed, Jan 17, 2024 at 10:38:13AM +1300, Hoorad Farrokh wrote:
> Fixed a coding style problem.
>
> Signed-off-by: Hoorad Farrokh <hourrad.f@xxxxxxxxx>
> ---
> drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index d5737166564e..a1adf69ba9f9 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1288,8 +1288,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>
> /* Set the driver state */
> /* Do we want the prism2 header? */
> - if ((msg->prismheader.status ==
> - P80211ENUM_msgitem_status_data_ok) &&
> + if (msg->prismheader.status ==
> + P80211ENUM_msgitem_status_data_ok &&
> (msg->prismheader.data == P80211ENUM_truth_true)) {
> hw->sniffhdr = 0;
> wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> --
> 2.42.0
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.

- You sent a patch that has been sent multiple times in the past, and is
identical to ones that has been rejected. Please always look at the
mailing list traffic to determine if you are duplicating other
people's work.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot