Re: [PATCH 1/3] usb: ucsi: Add missing ppm_lock

From: Greg Kroah-Hartman
Date: Wed Jan 17 2024 - 00:44:53 EST


On Tue, Jan 16, 2024 at 11:40:39PM +0100, Christian A. Ehrhardt wrote:
> Calling ->sync_write must be done while holding the PPM lock as the
> mailbox logic does not support concurrent commands.
>
> Thus protect the only call to ucsi_acknowledge_connector_change
> with the PPM lock as it calls ->sync_write. All other calls to
> ->sync_write already happen under the PPM lock.
>
> Signed-off-by: Christian A. Ehrhardt <lk@xxxxxxx>
> ---
> NOTE: This is not a theoretical issue. I've seen problems resulting
> from the missing lock on real hardware.

What commit id does this fix?

Should it be cc: stable?

thanks,

greg k-h