Re: [PATCH][next] net: microchip: sparx5: remove redundant store to variable clk_hz

From: Jakub Kicinski
Date: Tue Jan 16 2024 - 20:53:42 EST


On Tue, 16 Jan 2024 16:18:47 +0000 Colin Ian King wrote:
> The store to clk_hz is redundant since clk_hz goes out of scope on the
> return. Fix this by replacing the *= operator with just * to remove
> the store back to clk_hz.
>
> Cleans up clang scan build warning:
> warning: Although the value stored to 'clk_hz' is used in the enclosing
> expression, the value is never actually read from 'clk_hz'
> [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

For consistency - same story as:
https://lore.kernel.org/all/20240116193152.GD588419@xxxxxxxxxx/
--
pw-bot: defer