Re: vfio/platform: Use common error handling code in vfio_set_trigger()

[Alex Williamson]

On Tue, 16 Jan 2024 12:32:23 +0100
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> > TBH, this doesn't seem like a worthwhile exit point consolidation.  A
> > change like this might be justified if there were some common unlock
> > code that could be shared, but for a simple free and return errno by
> > jumping to a different exception block, rather than even a common exit
> > block, I don't see the value.  
> 
> Can it be helpful to store the shown kfree() call only once
> in this function implementation?

I don't believe it's worthwhile, it's a simple function with simple
exit paths and consolidating those exit paths for a trivial kfree() is
unnecessarily complex.  Thanks,

Alex