RE: [EXT] Re: [PATCH 1/1] net: mvpp2: clear BM pool before initialization
From: Jenishkumar Patel [C]
Date: Tue Jan 16 2024 - 06:42:41 EST
-----Original Message-----
From: Russell King <linux@xxxxxxxxxxxxxxx>
Sent: Tuesday, January 16, 2024 2:56 PM
To: Jenishkumar Patel [C] <jpatel2@xxxxxxxxxxx>
Cc: marcin.s.wojtas@xxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxx
Subject: [EXT] Re: [PATCH 1/1] net: mvpp2: clear BM pool before initialization
External Email
----------------------------------------------------------------------
On Mon, Jan 15, 2024 at 09:57:54PM -0800, Jenishkumar Maheshbhai Patel wrote:
> static int mvpp2_bm_init(struct device *dev, struct mvpp2 *priv) {
> enum dma_data_direction dma_dir = DMA_FROM_DEVICE;
> int i, err, poolnum = MVPP2_BM_POOLS_NUM;
> struct mvpp2_port *port;
>
> + if (priv->percpu_pools)
> + poolnum = mvpp2_get_nrxqs(priv) * 2;
> +
> + for (i = 0; i < poolnum; i++) {
> + /* Make sure about the pool state in case it was
> + * used by firmware.
> + */
> + mvpp2_bm_pool_cleanup(priv, i);
> + }
/* Clean up the pool state in case it contains stale state */
for (i = 0; i < poolnum; i++)
mvpp2_bm_pool_cleanup(priv, i);
Doesn't need quite as many lines!
I will address the comments in v2
--
RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https-3A__www.armlinux.org.uk_developer_patches_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=weFk2fYEO0yNIZAlSXwm82u5QM08YlNJaQ39RhfTtUo&m=2U4cWAQSanajVfFvpZbZdhHMcQ4rsCILgPZ1Nk_k-CE3HMuIv3y5IPWQ4KgdJgAG&s=IbrApY-e2TWgCw8YQJc7W48jpUGy29BTy_MfcTkwQ8I&e=
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!