Re: [PATCH AUTOSEL 5.4 7/7] selftests/nolibc: use EFI -bios for LoongArch qemu

[Sasha Levin]

On Tue, Jan 16, 2024 at 07:50:17PM +0900, Masahiro Yamada wrote:
> On Tue, Jan 16, 2024 at 9:15 AM Sasha Levin <sashal@xxxxxxxxxx> wrote:
> > From: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> >
> > [ Upstream commit bdeeeaba83682225a7bf5f100fe8652a59590d33 ]
> >
> > qemu for LoongArch does not work properly with direct kernel boot.
> > The kernel will panic during initialization and hang without any output.
> >
> > When booting in EFI mode everything work correctly.
> >
> > While users most likely don't have the LoongArch EFI binary installed at
> > least an explicit error about 'file not found' is better than a hanging
> > test without output that can never succeed.
> >
> > Link: https://lore.kernel.org/loongarch/1738d60a-df3a-4102-b1da-d16a29b6e06a@xxxxxxxx/
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > Acked-by: Willy Tarreau <w@xxxxxx>
> > Link: https://lore.kernel.org/r/20231031-nolibc-out-of-tree-v1-1-47c92f73590a@xxxxxxxxxxxxxx
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  Makefile | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
>
>
>
>
> This backport makes me upset.
>
> The original commit, bdeeeaba83682225a7bf5f100fe8652a59590d33,
> changed tools/testing/selftests/nolibc/Makefile.
>
>
> However, this backport changes the top Makefile.
>
>
> What is happening in the back-port logic?

I'm... not entierly sure. This wasn't hand massaged.

I'll drop it from everywhere.

--
Thanks,
Sasha