Re: [PATCH v8 1/5] dt-bindings: clock: sophgo: add sysclk for SG2042

From: Krzysztof Kozlowski
Date: Tue Jan 16 2024 - 05:09:14 EST


On 16/01/2024 08:20, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@xxxxxxxxxxx>
>
> Add bindings for the clocks of which configuration registers are in the
> range of SYS_CTRL in the memory-map.

This means it is not a separate device and should be just merged with
parent node. Otherwise please give us some arguments why this should be
a separate device node.


>
> Signed-off-by: Chen Wang <unicorn_wang@xxxxxxxxxxx>
>
> .

Some stray characters above ^^^. Clean your commit msg. Also, I have
doubts it passes checkpatch.


Best regards,
Krzysztof