Re: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages

[Gang Li]

On 2024/1/16 15:02, Muchun Song wrote:
> On 2024/1/2 21:12, Gang Li wrote:
> > hugetlb_hstate_alloc_pages_gigantic(struct hstate *h)
>
> The name is so long, how about hugetlb_gigantic_pages_alloc_boot?
>
> > hugetlb_hstate_alloc_pages_non_gigantic(struct hstate *h)
>
> hugetlb_pages_alloc_boot?
LGTM.

> It it unnecessary to reverse the condition. A little sime like following:
>
> if (hstate_is_gigantic(h))
>     /* gigantic pages */
> else
>     /* normal pages */

Will take it in next version.