Re: [PATCH v2 1/2] usb: dwc3: host: Set XHCI_SG_TRB_CACHE_SIZE_QUIRK

[Prashanth K]

On 11-01-24 03:46 pm, Hans de Goede wrote:
> > ---
> >   drivers/usb/dwc3/host.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> > index 61f57fe5bb78..31a496233d87 100644
> > --- a/drivers/usb/dwc3/host.c
> > +++ b/drivers/usb/dwc3/host.c
> > @@ -89,6 +89,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> >   
> >   	memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));
> >   
> > +	props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-sg-trb-cache-size-quirk");
> > +
>
> If you do this you also need to make the props array 1 entry bigger (increase
> it from 4 to 5 entries). Before this patch there are max 3 properties added
> and there needs to be an empty terminating property at the end (which
> is what the memset is for). So before this patch props[] needs to have
> 4 entries (which it does) and thus after this patch props[] needs to
> have 5 entire.s
>
> Regards,
>
> Hans
Thanks for pointing this out Hans! Didn't change it from 4->5 since we 
had only 4 properties, wasn't aware of the terminating property. Will 
update the patch.

Thanks again
Prashanth K