Re: [PATCH v2 08/13] mm/gup: Handle hugetlb for no_page_table()

From: Jason Gunthorpe
Date: Mon Jan 15 2024 - 13:40:00 EST


On Wed, Jan 03, 2024 at 05:14:18PM +0800, peterx@xxxxxxxxxx wrote:
> From: Peter Xu <peterx@xxxxxxxxxx>
>
> no_page_table() is not yet used for hugetlb code paths. Make it prepared.
>
> The major difference here is hugetlb will return -EFAULT as long as page
> cache does not exist, even if VM_SHARED. See hugetlb_follow_page_mask().
>
> Pass "address" into no_page_table() too, as hugetlb will need it.
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: Peter Xu <peterx@xxxxxxxxxx>
> ---
> mm/gup.c | 44 ++++++++++++++++++++++++++------------------
> 1 file changed, 26 insertions(+), 18 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason