Re: [PATCH] dt-bindings: ignore paths outside kernel for DT_SCHEMA_FILES

[Michal Simek]

On 1/4/24 00:58, Rob Herring wrote:
> On Wed, 20 Dec 2023 14:55:37 +0000, André Draszik wrote:
> > If the location of the kernel sources contains the string that we're
> > filtering for using DT_SCHEMA_FILES, then all schemas will currently be
> > matched, returned and checked, not just the ones we actually expected.
> > As an example, if the kernel sources happen to be below a directory
> > 'google', and DT_SCHEMA_FILES=google, everything is checked. More
> > common examples might be having the sources below people's home
> > directories that contain the string st or arm and then searching for
> > those. The list is endless.
> >
> > Fix this by only matching for schemas below the kernel source's
> > bindings directory.
> >
> > Note that I opted for the implementation here so as to not having to
> > deal with escaping DT_SCHEMA_FILES, which would have been the
> > alternative if the grep match itself had been updated.
> >
> > Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks!

This patch is causing issue for me. Look at log below.
I am running it directly on the latest linux-next/master.

Thanks,
Michal

$ make DT_SCHEMA_FILES="Documentation/devicetree/bindings/arm/arm,cci-400.yaml" 
dt_binding_check
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTLD  scripts/dtc/dtc
  HOSTCC  scripts/dtc/libfdt/fdt.o
  HOSTCC  scripts/dtc/libfdt/fdt_ro.o
  HOSTCC  scripts/dtc/libfdt/fdt_wip.o
  HOSTCC  scripts/dtc/libfdt/fdt_sw.o
  HOSTCC  scripts/dtc/libfdt/fdt_rw.o
  HOSTCC  scripts/dtc/libfdt/fdt_strerror.o
  HOSTCC  scripts/dtc/libfdt/fdt_empty_tree.o
  HOSTCC  scripts/dtc/libfdt/fdt_addresses.o
  HOSTCC  scripts/dtc/libfdt/fdt_overlay.o
  HOSTCC  scripts/dtc/fdtoverlay.o
  HOSTLD  scripts/dtc/fdtoverlay
  LINT    Documentation/devicetree/bindings
usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f 
{parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...]
yamllint: error: one of the arguments FILE_OR_DIR - is required
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json