Re: [PATCH v2] cxl: Fix null pointer dereference in cxl_get_fd

From: Andrew Donnellan
Date: Mon Jan 15 2024 - 00:03:49 EST


On Fri, 2024-01-12 at 13:49 +0800, Kunwu Chan wrote:

> +err:
> + if (rc < 0)
> + return ERR_PTR(rc);
>   return NULL;

I don't think there's a way for this NULL to ever get returned?

Apart from that it looks good:

Reviewed-by: Andrew Donnellan <ajd@xxxxxxxxxxxxx>

--
Andrew Donnellan OzLabs, ADL Canberra
ajd@xxxxxxxxxxxxx IBM Australia Limited