Re: [PATCH v2 2/5] dt-bindings: rtc: abx80x: convert to yaml

From: Josua Mayer
Date: Sun Jan 14 2024 - 11:26:41 EST


Am 14.01.24 um 16:56 schrieb Josua Mayer:

> Am 12.01.24 um 18:18 schrieb Krzysztof Kozlowski:
>> On 12/01/2024 18:12, Josua Mayer wrote:
>>> +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
>>> @@ -0,0 +1,56 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/rtc/abracon,abx80x.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Abracon ABX80X I2C ultra low power RTC/Alarm chip
>>> +
>>> +maintainers: []
>> You need a name here. If there is no driver maintainer or anyone
>> interested, put devicetree list.
> Ack.
>>> +
>>> +allOf:
>>> + - $ref: rtc.yaml#

+ $ref: /schemas/interrupts.yaml#

Is it acceptable to reference generic interrupts schema?:

I see no rtc yaml doing that, and only some describe interrupts property explicitly. But Importing the schema would also cover -parent and -names.

>>> +
>>> + interrupts:
>>> + maxItems: 1


sincerely
Josua Mayer