Re: [PATCH] KEYS: include header for EINVAL definition

From: Jarkko Sakkinen
Date: Sat Jan 13 2024 - 15:47:11 EST


On Fri Jan 12, 2024 at 7:59 AM EET, Clay Chang wrote:
> Hi Jarkko,
>
> Yes, I have. I am working on an OpenBMC project and the kernel .config was generated by merging several config fragments. In one experiment where the CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not presented, I got a EINVAL undeclared compilation error.
>
> Do you want me to show the full .config here?

Well the problem with the patch is that it does not *prove*
that there is issue.

So you evidence in the commit message that there is bug in
the first place and which config options cause it. And it
it must be testable with latest mainline (not by downstream
project).

BR, Jarkko