Re: [PATCH v2 3/3] iio: light: as73211: add support for as7331

From: Jonathan Cameron
Date: Sat Jan 13 2024 - 10:16:06 EST


> > +struct as73211_data;
> > +
> > +/**
> > + * struct spec_dev_data - device-specific data
> > + * @intensity_scale: Function to retrieve intensity scale values.
> > + * @channel: Device channels.
> > + * @num_channels: Number of channels of the device.
> > + */
> > +struct spec_dev_data {
>
> I would call it as73211_spec_dev_data (is the C++ One Definition Rule relevant for
> the kernel?)
>
> > + int (*intensity_scale)(struct as73211_data *data, int chan, int *val, int *val2);
> > + struct iio_chan_spec const *channel;
> s/channel/channels/
>
> > + int num_channels;
> > +};
Both good suggestions so I've applied them both and pushed out a new version of
the togreg tree.

Thanks,
Jonathan