Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board

[Conor Dooley]

On Fri, Jan 12, 2024 at 06:02:09PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 17:58, Conor Dooley wrote:
> > On Fri, Jan 12, 2024 at 10:42:30PM +0900, KyuHyuk Lee wrote:
> >> Add device tree binding for Hardkernel ODROID-M1S board based on
> >> RK3566 SoC.
> >>
> >> Signed-off-by: KyuHyuk Lee <lee@xxxxxxxxxx>
> >> ---
> >>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> index 5cf5cbef2cf5..cc37d2118131 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> @@ -566,6 +566,11 @@ properties:
> >>            - const: rockchip,rk3568-odroid-m1
> >>            - const: rockchip,rk3568
> >>  
> >> +      - description: Hardkernel Odroid M1S
> > 
> > if the vendor for this board is hardkernel...
> > 
> >> +        items:
> >> +          - const: rockchip,rk3566-odroid-m1s
> > 
> > ...why is the vendor prefix here rockchip?
> 
> Uh, good catch. I missed it when acking their earlier mistake year ago
> :( Would be nice if they fixed that one too.

Maybe they will if they got your email, they did not get mine
apparently:
<lee@xxxxxxxxxx>: host mx02.mail.icloud.com[17.57.155.34] said: 554 5.7.1
    [HM08] Message rejected due to local policy. Please visit
    https://support.apple.com/en-us/HT204137 (in reply to end of DATA command)

Attachment: signature.asc
Description: PGP signature