Re: [PATCH v6 3/6] PCI: qcom: Add missing icc bandwidth vote for cpu to PCIe path

From: Bryan O'Donoghue
Date: Fri Jan 12 2024 - 10:17:42 EST


On 12/01/2024 14:22, Krishna chaitanya chundru wrote:
CPU-PCIe path consits for registers PCIe BAR space, config space.
As there is less access on this path compared to pcie to mem path
add minimum vote i.e GEN1x1 bandwidth always.

In suspend remove the cpu vote after register space access is done.

Fixes: c4860af88d0c ("PCI: qcom: Add basic interconnect support")

If this patch is a Fixes then don't you need the accompanying dts change as a parallel Fixes too ?

i.e. without the dts update - you won't have the nodes in the dts to consume => applying this code to the stable kernel absent the dts will result in no functional change and therefore no bugfix.

I'm not sure if you are asked to put a Fixes here but it seems to be it should either be dropped or require a parallel Fixes: tag for the dts and yaml changes.

What is the bug this change fixes in the backport ?

cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx>

---
bod