Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

From: Linus Walleij
Date: Thu Jan 11 2024 - 09:57:35 EST


On Wed, Jan 10, 2024 at 4:14 PM Luca Weiss <luca.weiss@xxxxxxxxxxxxx> wrote:

> Add support for the 2340x1080 LCD DJN panel bundled with a HX83112A
> driver IC, as found on the Fairphone 4 smartphone.
>
> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>

This makes it sound like the Himax HX83112A is the driver IC.

This does not seem to be the case:
https://github.com/HimaxSoftware/HX83112_Android_Driver

The driver IC seems to be a truly 5p65.

If this is right, could you rename the driver file to truly-5p65.c
and all symbols containing hx83112 to truly_5965 or something
that indicate the driver IC instead of the panel?

My main concern is that the next display using the same IC
need to find the right file to patch.

Yours,
Linus Walleij