Re: [PATCH v5 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable
From: Petr Mladek
Date: Thu Jan 11 2024 - 08:14:47 EST
On Tue 2024-01-09 21:24:54, Marcos Paulo de Souza wrote:
> Add TEST_GEN_MODS_DIR variable for kselftests. It can point to
> a directory containing kernel modules that will be used by
> selftest scripts.
>
> The modules are built as external modules for the running kernel.
> As a result they are always binary compatible and the same tests
> can be used for older or newer kernels.
>
> The build requires "kernel-devel" package to be installed.
> For example, in the upstream sources, the rpm devel package
> is produced by "make rpm-pkg"
>
> The modules can be built independently by
>
> make -C tools/testing/selftests/livepatch/
>
> or they will be automatically built before running the tests via
>
> make -C tools/testing/selftests/livepatch/ run_tests
>
> Note that they are _not_ built when running the standalone
> tests by calling, for example, ./test-state.sh.
>
> Along with TEST_GEN_MODS_DIR, it was necessary to create a new install
> rule. INSTALL_MODS_RULE is needed because INSTALL_SINGLE_RULE would
> copy the entire TEST_GEN_MODS_DIR directory to the destination, even
> the files created by Kbuild to compile the modules. The new install
> rule copies only the .ko files, as we would expect the gen_tar to work.
>
> Reviewed-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
I am not export on kbuild. But it looks reasonable and works for me.
Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
Best Regards,
Petr