Re: [PATCH v2] ubifs: Remove unreachable code in dbg_check_ltab_lnum

[Zhihao Cheng]

在 2024/1/11 14:36, Kunwu Chan 写道:
> Because there is no break statement in the dead loop above,it is
> impossible to execute the 'err=0' statement.Delete the code that
> will never execute.
>
> Fixes: 6fb324a4b0c3 ("UBIFS: allocate ltab checking buffer on demand")
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
> Cc: Kunwu Chan <kunwu.chan@xxxxxxxxxxx>
> Suggested-by: Richard Weinberger <richard.weinberger@xxxxxxxxx>
>
> ---
> v2: Remove the initialization of err
> ---
>   fs/ubifs/lpt_commit.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>

> diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
> index c4d079328b92..07351fdce722 100644
> --- a/fs/ubifs/lpt_commit.c
> +++ b/fs/ubifs/lpt_commit.c
> @@ -1646,7 +1646,6 @@ static int dbg_check_ltab_lnum(struct ubifs_info *c, int lnum)
>   		len -= node_len;
>   	}
>   
> -	err = 0;
>   out:
>   	vfree(buf);
>   	return err;