Re: [PATCH v22 1/8] dt-bindings: clock: npcm845: Add reference 25m clock property

From: Stephen Boyd
Date: Wed Jan 10 2024 - 16:46:11 EST


Quoting Krzysztof Kozlowski (2024-01-10 12:54:14)
> On 10/01/2024 14:47, Tomer Maimon wrote:
> >>> +
> >>> + clock-names:
> >>> + items:
> >>> + - const: refclk
> >>> +
> >>> '#clock-cells':
> >>> const: 1
> >>> description:
> >>> @@ -30,12 +38,20 @@ properties:
> >>> required:
> >>> - compatible
> >>> - reg
> >>> + - clocks
> >>> + - clock-names
> >>
> >> New required properties are an ABI break. That's fine if you explain why
> >> that's okay in the commit msg.
> > What do you mean?
>
> I think it was clear. Which part is not clear?
>
> > Could I add the new required properties to the required list?
>
> You just did, didn't you? And received feedback that you are breaking
> the ABI.
>

It's fine to break the ABI as long as the commit message explains that
the driver isn't merged yet.