Re: [PATCH 2/6] dt-bindings: iio: pressure: honeywell,hsc030pa.yaml add sleep-mode

From: Krzysztof Kozlowski
Date: Wed Jan 10 2024 - 15:51:19 EST


On 10/01/2024 18:22, Petre Rodan wrote:
> Add sleep-mode property present in some custom chips.
>
> This flag activates a special wakeup sequence prior to conversion.
>
> Signed-off-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx>
> ---
> .../bindings/iio/pressure/honeywell,hsc030pa.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml
> index 89977b9f01cf..350da1d6991b 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml
> @@ -86,6 +86,15 @@ properties:
> Maximum pressure value the sensor can measure in pascal.
> To be specified only if honeywell,pressure-triplet is set to "NA".
>
> + honeywell,sleep-mode:

"Sleep mode" naming suggests there are choices, like mode foo and mode
bar. Probably you want something like "sleep-between-measurements" or
something matching how does it work.


> + description: |

Do not need '|' unless you need to preserve formatting.

> + 'Sleep Mode' is a special factory set mode of the chip that allows the
> + sensor to power down between measurements. It is implemented only on
> + special request, and it is an attribute not present in the HSC/SSC series
> + nomenclature.
> + Set in order to enable the special wakeup sequence prior to conversion.
> + $ref: /schemas/types.yaml#/definitions/flag
> +
> vdd-supply:
> description:
> Provide VDD power to the sensor (either 3.3V or 5V depending on the chip)
> @@ -140,6 +149,7 @@ examples:
> honeywell,pressure-triplet = "NA";
> honeywell,pmin-pascal = <0>;
> honeywell,pmax-pascal = <200000>;
> + //honeywell,sleep-mode;

Drop comment.

> 2.41.0
>

Best regards,
Krzysztof