Re: [PATCH v2 5/8] buffer: Add kernel-doc for brelse() and __brelse()

From: Pankaj Raghav (Samsung)
Date: Wed Jan 10 2024 - 15:10:37 EST


On Wed, Jan 10, 2024 at 05:26:55PM +0000, Matthew Wilcox wrote:
> On Wed, Jan 10, 2024 at 03:30:54PM +0100, Pankaj Raghav (Samsung) wrote:
> > > + * If all buffers on a folio have zero reference count, are clean
> > > + * and unlocked, and if the folio is clean and unlocked then
> >
> > IIUC from your [PATCH 3/8], folio only needs to be unlocked to free the
> > buffers as try_to_free_buffers() will remove the dirty flag and "clean"
> > the folio?
> > So:
> > s/if folio is clean and unlocked/if folio is unlocked
>
> That's a good point. Perhaps "unlocked and not under writeback"
> would be better wording, since that would be true.

Yeah. That sounds good to me!