Re: [PATCH 1/4] netfilter: nfnetlink_log: use proper helper for fetching physinif

From: Florian Westphal
Date: Wed Jan 10 2024 - 09:01:40 EST


Pavel Tikhomirov <ptikhomirov@xxxxxxxxxxxxx> wrote:
> On 10/01/2024 21:33, Florian Westphal wrote:
> > Pavel Tikhomirov <ptikhomirov@xxxxxxxxxxxxx> wrote:
> > I think you can drop this patch and make the last patch pass
> > nf_bridge_info->physinif directly.
>
> The whole Idea of this patch was to replace nf_bridge_get_physindev with
> nf_bridge_get_physinif before the patch which propagates net, so that we
> don't need to propagate net first and then in later patch remove it when
> replacing with nf_bridge_get_physinif.
>
> But I spoiled it by forgetting to remove net propagation to
> __build_packet_message...
>
> Is it ok if I leave this patch as is, but instead remove:

Yes, thats fine.