Re: [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC

From: Krzysztof Kozlowski
Date: Wed Jan 10 2024 - 07:14:15 EST


On 10/01/2024 12:20, Luo Jie wrote:
> The PPE(packet process engine) hardware block is supported by Qualcomm
> IPQ platforms, such as IPQ9574 and IPQ5332. The PPE includes the various
> packet processing modules such as the routing and bridging flow engines,
> L2 switch capability, VLAN and tunnels. Also included are integrated
> ethernet MAC and PCS(uniphy), which is used to connect with the external
> PHY devices by PCS.
>
> This patch series enables support for the following DTSI functionality
> for Qualcomm IPQ9574 and IPQ5332 chipsets.
>
> 1. Add PPE (Packet Processing Engine) HW support
>
> 2. Add IPQ9574 RDP433 board support, where the PPE is connected
> with qca8075 PHY and AQ PHY.
>
> 3. Add IPQ5332 RDP441 board support, where the PPE is connected
> with qca8386 and SFP
>
> PPE DTS depends on the NSSCC clock driver below, which provides the
> clocks for the PPE driver.

DTS cannot depend on clock drivers. Maybe you meant that it depends on
NSSCC clock controller DTS changes, which would be fine. However
depending on drivers is neither necessary nor allowed.

Best regards,
Krzysztof