Re: [PATCH v2 0/2] lib min_heap: Min heap optimizations

From: Andrew Morton
Date: Wed Jan 10 2024 - 01:15:00 EST


On Thu, 4 Jan 2024 04:52:57 +0800 Kuan-Wei Chiu <visitorckw@xxxxxxxxx> wrote:

> Hello,
>
> The purpose of this patch series is to enhance the existing min heap
> implementation. The optimization focuses on both the heap construction
> process and the number of comparisons made during the heapify
> operation.
>

The patches look nice, but the only user of this code is
kernel/events/core.c and the developers of that code aren't cc'ed, so
please rectify that.

Has Ian commented on these changes?

The amount of inlining in min_heap.h is amazing. Was there some
special reason for this? It makes min_heap somewhat unsuitable for
more general use.