Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset

From: Anthony Krowiak
Date: Tue Jan 09 2024 - 12:02:44 EST



On 12/4/23 5:05 PM, Halil Pasic wrote:
On Mon, 4 Dec 2023 12:51:49 -0500
Tony Krowiak <akrowiak@xxxxxxxxxxxxx> wrote:

s/if\/when/at latest before/

I would argue that some of the cleanups need to happen before even 01 is
reflected...
To what cleanups are you referring?
Event notification and interruption disablement for starters. Otherwise
OS has no way to figure out when is GISA and NIB safe to deallocate.
Those actions are part of the reset process. I.e. some of the reset stuff
can be deferred at most until the queue is made accessible again, some
not so much.


How do you propose we disable interrupts if the PQAP(AQIC) will likely fail with response code 01 which is the subject of this patch? Do you think we should not free up the AQIC resources as we do in this patch?



Regards,
Halil