RE: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support

[ChunHau Tan]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, 9 January, 2024 3:59 PM
> To: ChunHau Tan <chunhau.tan@xxxxxxxxxxxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Emil Renner Berthing <kernel@xxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Maxime Coquelin
> <mcoquelin.stm32@xxxxxxxxx>; Alexandre Torgue
> <alexandre.torgue@xxxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>;
> Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>; Andrew Halaney
> <ahalaney@xxxxxxxxxx>; Jisheng Zhang <jszhang@xxxxxxxxxx>; Uwe
> Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Russell King
> <rmk+kernel@xxxxxxxxxxxxxxx>
> Cc: Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>; JeeHeng Sia
> <jeeheng.sia@xxxxxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support
> 
> On 09/01/2024 08:25, ChunHau Tan wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> Sent: Monday, 8 January, 2024 5:07 PM
> >> To: ChunHau Tan <chunhau.tan@xxxxxxxxxxxxxxxx>; David S . Miller
> >> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> >> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Rob
> >> Herring <robh+dt@xxxxxxxxxx>; Emil Renner Berthing <kernel@xxxxxxxx>;
> >> Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> >> <krzysztof.kozlowski+dt@xxxxxxxxxx>;
> >> Conor Dooley <conor+dt@xxxxxxxxxx>; Maxime Coquelin
> >> <mcoquelin.stm32@xxxxxxxxx>; Alexandre Torgue
> >> <alexandre.torgue@xxxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>;
> >> Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>; Andrew Halaney
> >> <ahalaney@xxxxxxxxxx>; Jisheng Zhang <jszhang@xxxxxxxxxx>; Uwe
> >> Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Russell King
> >> <rmk+kernel@xxxxxxxxxxxxxxx>
> >> Cc: Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>; JeeHeng Sia
> >> <jeeheng.sia@xxxxxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> >> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> >> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> >> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac
> >> support
> >>
> >> On 08/01/2024 08:58, Tan Chun Hau wrote:
> >>> Add JH8100 dwmac support.
> >>>
> >>> Signed-off-by: Tan Chun Hau <chunhau.tan@xxxxxxxxxxxxxxxx>
> >>> ---
> >>>  drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >> b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> index 5d630affb4d1..373714f6e382 100644
> >>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct
> >> platform_device *pdev)
> >>>
> >>>  static const struct of_device_id starfive_dwmac_match[] = {
> >>>  	{ .compatible = "starfive,jh7110-dwmac"	},
> >>> +	{ .compatible = "starfive,jh8100-dwmac"	},
> >>
> >> No differences? Then why aren't the devices made compatible with each
> >> other?
> > There is a difference between JH7110 & JH8110,
> > JH7110 has two reset signals (ahb, stmmaceth), while JH8110 has only
> > one reset signal (stmmaceth), this will be shown in device tree file.
> 
> So if you are so picky then again: No differences in the driver? Then use
> compatibility or provide real arguments. NAK.
There are no differences in the driver.
Okay, the driver will remain the same, I will drop this change in V2. 
Thank you for the feedback.
> 
> Best regards,
> Krzysztof