RE: [PATCH 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support

[ChunHau Tan]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Monday, 8 January, 2024 4:28 PM
> To: ChunHau Tan <chunhau.tan@xxxxxxxxxxxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Emil Renner Berthing <kernel@xxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Maxime Coquelin
> <mcoquelin.stm32@xxxxxxxxx>; Alexandre Torgue
> <alexandre.torgue@xxxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>;
> Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>; Andrew Halaney
> <ahalaney@xxxxxxxxxx>; Jisheng Zhang <jszhang@xxxxxxxxxx>; Uwe
> Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Russell King
> <rmk+kernel@xxxxxxxxxxxxxxx>
> Cc: Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>; JeeHeng Sia
> <jeeheng.sia@xxxxxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add
> StarFive JH8100 support
> 
> On 08/01/2024 08:58, Tan Chun Hau wrote:
> > Add StarFive JH8100 dwmac support.
> > JH8100 dwmac has one reset signal instead of 2 resets as in JH7110.
> >
> > Signed-off-by: Tan Chun Hau <chunhau.tan@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/net/starfive,jh7110-dwmac.yaml   | 28 ++++++++++++-------
> >  1 file changed, 18 insertions(+), 10 deletions(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > index 5e7cfbbebce6..3d0447726902 100644
> > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > +++
> b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > @@ -17,6 +17,7 @@ select:
> >        contains:
> >          enum:
> >            - starfive,jh7110-dwmac
> > +          - starfive,jh8100-dwmac
> 
> I have doubts that you tested it. Missing change to snps,dwmac.
Will fix in V2.
> 
> >    required:
> >      - compatible
> >
> > @@ -25,6 +26,7 @@ properties:
> >      items:
> >        - enum:
> >            - starfive,jh7110-dwmac
> > +          - starfive,jh8100-dwmac
> >        - const: snps,dwmac-5.20
> >
> >    reg:
> > @@ -54,16 +56,6 @@ properties:
> >      minItems: 3
> >      maxItems: 3
> >
> > -  resets:
> > -    items:
> > -      - description: MAC Reset signal.
> > -      - description: AHB Reset signal.
> > -
> > -  reset-names:
> > -    items:
> > -      - const: stmmaceth
> > -      - const: ahb
> > -
> >    starfive,tx-use-rgmii-clk:
> >      description:
> >        Tx clock is provided by external rgmii clock.
> > @@ -93,6 +85,22 @@ required:
> >
> >  allOf:
> >    - $ref: snps,dwmac.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - starfive,jh7110-dwmac
> > +    then:
> > +      properties:
> > +        resets:
> > +          items:
> > +            - description: MAC Reset signal.
> > +            - description: AHB Reset signal.
> > +        resets-names:
> > +          items:
> > +            - const: stmmaceth
> > +            - const: ahb
> 
> Missing else: narrowing your jh8100.
Will fix in V2.
> 
> Best regards,
> Krzysztof