Re: [PATCH 2/3] cifs: make cifs_chan_update_iface() a void function

From: Dan Carpenter
Date: Tue Jan 09 2024 - 02:40:43 EST


On Mon, Jan 08, 2024 at 08:09:17PM +0100, Christophe JAILLET wrote:
> > @@ -478,13 +475,13 @@ cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
> > chan_index = cifs_ses_get_chan_index(ses, server);
> > if (chan_index == CIFS_INVAL_CHAN_INDEX) {
> > spin_unlock(&ses->chan_lock);
> > - return 0;
> > + return;
> > }
> > ses->chans[chan_index].iface = iface;
> > spin_unlock(&ses->chan_lock);
> > - return rc;
> > + return;
>
> just remove this one?
>

Doh. Yeah. I'll send a v2 of this tomorrow.

regards,
dan carpenter