Re: [GIT PULL] x86/mm changes for v6.8

[Linus Torvalds]

On Mon, 8 Jan 2024 at 03:35, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>  - Robustify pfn_to_kaddr()
>
>  - Improve the __untagged_addr() code: RIP-relative addresses are fine these days
>    and generate better code, and update misleading/outdated comments as well.

This does not even compile for me.

  arch/x86/include/asm/uaccess_64.h: In function ‘__untagged_addr’:
  arch/x86/include/asm/uaccess_64.h:25:28: error: implicit declaration
of function ‘__my_cpu_var’; did you mean ‘put_cpu_var’?
[-Werror=implicit-function-declaration]

WTH?

Maybe this has worked in your tree by mistake because there was some
branch dependency that just happened to work out because you had
merged things in a different order.

But that would very much not be ok regardless. Those branches should
be tested independently, and clearly they were not.

             Linus