Re: [PATCH v4 3/3] w1: add UART w1 bus driver

From: Krzysztof Kozlowski
Date: Mon Jan 08 2024 - 14:30:10 EST


On 08/01/2024 19:03, Christoph Winklhofer wrote:
> ...
>>> +static int w1_uart_serdev_receive_buf(struct serdev_device *serdev,
>>> + const unsigned char *buf, size_t count)
>>
>> serdev already uses u8 * here. You are basing on the top of some old tree.

Old? Your change came for v6.8 and this was sent when all trees were
based on v6.7-rc1. What newer tree could have this been?

> Yes, this patch is based on the w1-next branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git
> was not sure from where to start. I guess that this change is probably in
> the w1-tree after the next stable release.

That's a timing issue. For that particular case, where this was
targeting next-next cycle, you should have based this on linux-next. In
other cases this would require cross-tree merging due to dependencies
which none of us were aware, so no harm.


Best regards,
Krzysztof