Re: [PATCH v4 net-next 1/5] net: phy: Add BaseT1 auto-negotiation constants

From: Andrew Lunn
Date: Mon Jan 08 2024 - 08:51:08 EST


On Mon, Jan 08, 2024 at 10:36:56AM +0100, Dimitri Fedrau wrote:
> Added constants for advertising 100BT1 and 1000BT1 in register BASE-T1
> auto-negotiation advertisement register [31:16] (Register 7.515)
>
> Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx>
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Sorry, more nit-picking :-(

Signed-off-by, Reviewed-by:, Fixes: etc should all be together. No
blanks lines between them. And Signed-off-by: comes last.

Given the missing statics, it looks like you will need to repost in
two weeks times.

Andrew