Re: [PATCH 2/5] buffer: Add kernel-doc for block_dirty_folio()

From: Pankaj Raghav (Samsung)
Date: Mon Jan 08 2024 - 08:31:40 EST


> + * If the folio has buffers, the uptodate buffers are set dirty, to
> + * preserve dirty-state coherency between the folio and the buffers.
> + * It the folio does not have buffers then when they are later attached

s/It the folio/If the folio
> + * they will all be set dirty.
Is it better to rephrase it slightly as follows:

If the folio does not have buffers, they will all be set dirty when they
are later attached.

> + *
> + * The buffers are dirtied before the folio is dirtied. There's a small
> + * race window in which writeback may see the folio cleanness but not the
> + * buffer dirtiness. That's fine. If this code were to set the folio