Re: [PATCH v5 1/9] cxl/trace: Pass uuid explicitly to event traces

From: Jonathan Cameron
Date: Mon Jan 08 2024 - 07:57:07 EST


On Wed, 20 Dec 2023 16:17:28 -0800
Ira Weiny <ira.weiny@xxxxxxxxx> wrote:

> CXL CPER events are identified by the CPER Section Type GUID. The GUID
> correlates with the CXL UUID for the event record. It turns out that a
> CXL CPER record is a strict subset of the CXL event record, only the
> UUID header field is chopped.
>
> In order to unify handling between native and CPER flavors of CXL
> events, prepare the code for the UUID to be passed in rather than
> inferred from the record itself.
>
> Later patches update the passed in record to only refer to the common
> data between the formats.
>
> Pass the UUID explicitly to each trace event to be able to remove the
> UUID from the event structures.
>
> Originally it was desirable to remove the UUID from the well known event
> because the UUID value was redundant. However, the trace API was
> already in place.[1]
>
> [1] https://lore.kernel.org/all/36f2d12934d64a278f2c0313cbd01abc@xxxxxxxxxx/
>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>