Re: [PATCH v2] drm/tests: Add KUnit tests for drm_mode_create_dvi_i_properties()

From: Maxime Ripard
Date: Mon Jan 08 2024 - 05:50:07 EST


On Sat, Dec 23, 2023 at 03:59:33PM +0530, Dipam Turkar wrote:
> I needed some help regarding introducing a separate test for testing if the
> function still works if called a second time as suggested. Wouldn't we need
> to call it on the same object we called in the first time. So, that will
> bring redundancy in the two functions. Is this correct? Or am I
> understanding this wrong?

There will be redundancy indeed, but you're also not testing the same
thing so it's fine.

A test should be there to test one thing and one thing only.

Maxime

Attachment: signature.asc
Description: PGP signature