RE: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool support

[Shinas Rasheed]

Thanks for your review. Will submit V4 soon

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Saturday, January 6, 2024 9:03 AM
> To: Shinas Rasheed <srasheed@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Haseeb Gani
> <hgani@xxxxxxxxxxx>; Vimlesh Kumar <vimleshk@xxxxxxxxxxx>; Sathesh B
> Edara <sedara@xxxxxxxxxxx>; egallen@xxxxxxxxxx; mschmidt@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; horms@xxxxxxxxxx; wizhao@xxxxxxxxxx;
> kheib@xxxxxxxxxx; konguyen@xxxxxxxxxx; Veerasenareddy Burru
> <vburru@xxxxxxxxxxx>; Satananda Burla <sburla@xxxxxxxxxxx>; David S.
> Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>
> Subject: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool support
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Fri, 5 Jan 2024 12:38:22 -0800 Shinas Rasheed wrote:
> > +	"rx_dropped",
> > +	"tx_dropped",
> 
> Please take a close look at rtnl_link_stats64.
> Anything that fits should really go to standard interface stats.
> This will benefit the piles of monitoring SW which gather standard
> stats.
> 
> > +	"rx_dropped_pkts_fifo_full",
> 
> This one is probably rx_missed_errors