Re: [PATCH v5 0/1] dt-bindings: riscv: sophgo: add RTC for CV1800

From: Krzysztof Kozlowski
Date: Mon Jan 08 2024 - 03:02:46 EST


On 08/01/2024 08:22, Jingbao Qiu wrote:
> Real Time Clock (RTC) is an independently powered module
> within the chip, which includes a 32KHz oscillator and
> a Power On Reset/POR submodule. It can be used for time
> display and timed alarm generation.
>
> Power On Reset/POR submodule only using register resources
> so it should be empty. The 32KHz oscillator only provides
> pulses for RTC in hardware.
>
>
> Changes since v4:
> - remove POR dt-bindings because it empty
> - remove MFD dt-bindings because SoC does
> not have MFDs
> - add syscon attribute to share registers
> with POR
>
> v4: https://lore.kernel.org/all/20231229090643.116575-1-qiujingbao.dlmu@xxxxxxxxx/
>
> Changes since v3:
> - temporarily not submitting RTC driver code
> waiting for communication with IC designer

Hm, why?

We do not need bindings if nothing matches to them. If this binding is
for other upstream open-source project, please provide references.

See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L61

Best regards,
Krzysztof