kernel/crash_core.c:749:1: sparse: sparse: symbol '__crash_hotplug_lock' was not declared. Should it be static?

From: kernel test robot
Date: Sun Jan 07 2024 - 17:23:19 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0dd3ee31125508cd67f7e7172247f05b7fd1753a
commit: e2a8f20dd8e9df695f736e51cd9115ae55be92d1 Crash: add lock to serialize crash hotplug handling
date: 3 months ago
config: i386-randconfig-061-20240106 (https://download.01.org/0day-ci/archive/20240108/202401080654.IjjU5oK7-lkp@xxxxxxxxx/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240108/202401080654.IjjU5oK7-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401080654.IjjU5oK7-lkp@xxxxxxxxx/

sparse warnings: (new ones prefixed by >>)
>> kernel/crash_core.c:749:1: sparse: sparse: symbol '__crash_hotplug_lock' was not declared. Should it be static?

vim +/__crash_hotplug_lock +749 kernel/crash_core.c

741
742 /*
743 * Different than kexec/kdump loading/unloading/jumping/shrinking which
744 * usually rarely happen, there will be many crash hotplug events notified
745 * during one short period, e.g one memory board is hot added and memory
746 * regions are online. So mutex lock __crash_hotplug_lock is used to
747 * serialize the crash hotplug handling specifically.
748 */
> 749 DEFINE_MUTEX(__crash_hotplug_lock);
750 #define crash_hotplug_lock() mutex_lock(&__crash_hotplug_lock)
751 #define crash_hotplug_unlock() mutex_unlock(&__crash_hotplug_lock)
752

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki