Re: [PATCH] net: sfp: add quirk for DFP-34X-2C2 GPON ONU SFP

[Russell King (Oracle)]

On Sun, Jan 07, 2024 at 05:17:57PM +0100, Sergio Palumbo wrote:
>     Add a quirk for a GPON SFP that identifies itself as "OEM"
>     "DFP-34X-2C2". This module's PHY is accessible at 1000base-X,
>     but can also run at 2500base-X as per specs of the module.
>     After application of the quirk the module is enebled to run both
>     at 1000base-X as well as at 2500base-X interface mode.
> 
> Signed-off-by: Sergio Palumbo <palumbo.ser@xxxxxxxxxx>

There are several issues here:

1. Submitting to netdev needs either [PATCH net] or [PATCH net-next]
   to indicate which tree is being targetted. As this isn't a fix,
   net-next is appropriate, but I would also suggest that it is too
   late in the cycle as v6.7 is due out today.

2. How does the module switch between 1000base-X and 2500base-X?
   What happens if the module wants to use 2500base-X but the host
   doesn't support it? Please include these details in the commit
   message.

3. While I know the Turris Rollball entries are out of order, please
   try to keep the list alphabetically sorted, first by vendor string
   and then part string.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!