Re: [PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier to unsigned int

[Mark Brown]

On Sun, Jan 07, 2024 at 04:12:20PM +0100, Mirsad Todorovac wrote:

> mixer-test.c:350:80: warning: format ‘%ld’ expects argument of type ‘long int’, \
> 			      but argument 5 has type ‘unsigned int’ [-Wformat=]

If this is the issue then...

> -			ksft_print_msg("%s.%d value %ld more than item count %ld\n",
> +			ksft_print_msg("%s.%d value %ld more than item count %d\n",
>  				       ctl->name, index, int_val,
>  				       snd_ctl_elem_info_get_items(ctl->info));

...why are we not using an unsigned format specifier here?  I am very
suprised this doesn't continue to warn.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Attachment: signature.asc
Description: PGP signature