Re: [PATCH v1 1/1] selftests: net: increase timeout value for tests

From: Hangbin Liu
Date: Sun Jan 07 2024 - 07:50:12 EST


On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote:
> In particular, fcnal-test.sh timed out on slower hardware after
> some new permutations of tests were added.
>
> This single test ran for almost an hour instead of the expected
> 25 min (1500s). 75 minutes should suffice for most systems.
>
> Cc: David Ahern <dsahern@xxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-kselftest@xxxxxxxxxxxxxxx
> Signed-off-by: Mirsad Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
> ---
> tools/testing/selftests/net/settings | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
> index dfc27cdc6c05..ed8418e8217a 100644
> --- a/tools/testing/selftests/net/settings
> +++ b/tools/testing/selftests/net/settings
> @@ -1 +1 @@
> -timeout=1500
> +timeout=4500
> --
> 2.40.1
>

FYI, the net-next patch 779283b7770f ("selftests/net: convert fcnal-test.sh
to run it in unique namespace") has extended the timeout to 3600s.

Thanks
Hangbin