drivers/md/bcache/request.c:309: warning: Function parameter or member 'bch_data_insert' not described in 'CLOSURE_CALLBACK'
From: kernel test robot
Date: Sun Jan 07 2024 - 03:01:51 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 52b1853b080a082ec3749c3a9577f6c71b1d4a90
commit: d4e3b928ab487a8aecd1f6a140b40ac365116cfb closures: CLOSURE_CALLBACK() to fix type punning
date: 6 weeks ago
config: i386-buildonly-randconfig-001-20240107 (https://download.01.org/0day-ci/archive/20240107/202401071547.Zr3Ffy8F-lkp@xxxxxxxxx/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240107/202401071547.Zr3Ffy8F-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401071547.Zr3Ffy8F-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/md/bcache/request.c:309: warning: Function parameter or member 'bch_data_insert' not described in 'CLOSURE_CALLBACK'
>> drivers/md/bcache/request.c:309: warning: expecting prototype for bch_data_insert(). Prototype was for CLOSURE_CALLBACK() instead
vim +309 drivers/md/bcache/request.c
cafe563591446c Kent Overstreet 2013-03-23 287
cafe563591446c Kent Overstreet 2013-03-23 288 /**
a34a8bfd4e6358 Kent Overstreet 2013-10-24 289 * bch_data_insert - stick some data in the cache
47344e330eabc1 Bart Van Assche 2018-03-18 290 * @cl: closure pointer.
cafe563591446c Kent Overstreet 2013-03-23 291 *
cafe563591446c Kent Overstreet 2013-03-23 292 * This is the starting point for any data to end up in a cache device; it could
cafe563591446c Kent Overstreet 2013-03-23 293 * be from a normal write, or a writeback write, or a write to a flash only
cafe563591446c Kent Overstreet 2013-03-23 294 * volume - it's also used by the moving garbage collector to compact data in
cafe563591446c Kent Overstreet 2013-03-23 295 * mostly empty buckets.
cafe563591446c Kent Overstreet 2013-03-23 296 *
cafe563591446c Kent Overstreet 2013-03-23 297 * It first writes the data to the cache, creating a list of keys to be inserted
cafe563591446c Kent Overstreet 2013-03-23 298 * (if the data had to be fragmented there will be multiple keys); after the
cafe563591446c Kent Overstreet 2013-03-23 299 * data is written it calls bch_journal, and after the keys have been added to
cafe563591446c Kent Overstreet 2013-03-23 300 * the next journal write they're inserted into the btree.
cafe563591446c Kent Overstreet 2013-03-23 301 *
3db4d0783eaf2a Shenghui Wang 2018-12-13 302 * It inserts the data in op->bio; bi_sector is used for the key offset,
cafe563591446c Kent Overstreet 2013-03-23 303 * and op->inode is used for the key inode.
cafe563591446c Kent Overstreet 2013-03-23 304 *
3db4d0783eaf2a Shenghui Wang 2018-12-13 305 * If op->bypass is true, instead of inserting the data it invalidates the
3db4d0783eaf2a Shenghui Wang 2018-12-13 306 * region of the cache represented by op->bio and op->inode.
cafe563591446c Kent Overstreet 2013-03-23 307 */
d4e3b928ab487a Kent Overstreet 2023-11-17 308 CLOSURE_CALLBACK(bch_data_insert)
cafe563591446c Kent Overstreet 2013-03-23 @309 {
d4e3b928ab487a Kent Overstreet 2023-11-17 310 closure_type(op, struct data_insert_op, cl);
cafe563591446c Kent Overstreet 2013-03-23 311
60ae81eee86dd7 Slava Pestov 2014-05-22 312 trace_bcache_write(op->c, op->inode, op->bio,
60ae81eee86dd7 Slava Pestov 2014-05-22 313 op->writeback, op->bypass);
220bb38c21b83e Kent Overstreet 2013-09-10 314
220bb38c21b83e Kent Overstreet 2013-09-10 315 bch_keylist_init(&op->insert_keys);
220bb38c21b83e Kent Overstreet 2013-09-10 316 bio_get(op->bio);
d4e3b928ab487a Kent Overstreet 2023-11-17 317 bch_data_insert_start(&cl->work);
cafe563591446c Kent Overstreet 2013-03-23 318 }
cafe563591446c Kent Overstreet 2013-03-23 319
:::::: The code at line 309 was first introduced by commit
:::::: cafe563591446cf80bfbc2fe3bc72a2e36cf1060 bcache: A block layer cache
:::::: TO: Kent Overstreet <koverstreet@xxxxxxxxxx>
:::::: CC: Kent Overstreet <koverstreet@xxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki