drivers/firmware/stratix10-rsu.c:93: warning: Function parameter or member 'dcmf_status' not described in 'stratix10_rsu_priv'
From: kernel test robot
Date: Sun Jan 07 2024 - 01:40:18 EST
Hi Kah,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 52b1853b080a082ec3749c3a9577f6c71b1d4a90
commit: 1b4394c5d731593063f53df9d72467335c3b0367 firmware: stratix10-svc: extend svc to support RSU feature
date: 1 year, 6 months ago
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240107/202401071443.x9tmUlhW-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240107/202401071443.x9tmUlhW-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401071443.x9tmUlhW-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/firmware/stratix10-rsu.c:93: warning: Function parameter or member 'status' not described in 'stratix10_rsu_priv'
drivers/firmware/stratix10-rsu.c:93: warning: Function parameter or member 'dcmf_version' not described in 'stratix10_rsu_priv'
>> drivers/firmware/stratix10-rsu.c:93: warning: Function parameter or member 'dcmf_status' not described in 'stratix10_rsu_priv'
vim +93 drivers/firmware/stratix10-rsu.c
4526ebbc77732b Richard Gong 2019-09-03 37
4526ebbc77732b Richard Gong 2019-09-03 38 typedef void (*rsu_callback)(struct stratix10_svc_client *client,
4526ebbc77732b Richard Gong 2019-09-03 39 struct stratix10_svc_cb_data *data);
4526ebbc77732b Richard Gong 2019-09-03 40 /**
4526ebbc77732b Richard Gong 2019-09-03 41 * struct stratix10_rsu_priv - rsu data structure
4526ebbc77732b Richard Gong 2019-09-03 42 * @chan: pointer to the allocated service channel
4526ebbc77732b Richard Gong 2019-09-03 43 * @client: active service client
4526ebbc77732b Richard Gong 2019-09-03 44 * @completion: state for callback completion
4526ebbc77732b Richard Gong 2019-09-03 45 * @lock: a mutex to protect callback completion state
4526ebbc77732b Richard Gong 2019-09-03 46 * @status.current_image: address of image currently running in flash
4526ebbc77732b Richard Gong 2019-09-03 47 * @status.fail_image: address of failed image in flash
75bc73fc0188ef Richard Gong 2020-06-15 48 * @status.version: the interface version number of RSU firmware
4526ebbc77732b Richard Gong 2019-09-03 49 * @status.state: the state of RSU system
4526ebbc77732b Richard Gong 2019-09-03 50 * @status.error_details: error code
4526ebbc77732b Richard Gong 2019-09-03 51 * @status.error_location: the error offset inside the image that failed
75bc73fc0188ef Richard Gong 2020-06-15 52 * @dcmf_version.dcmf0: Quartus dcmf0 version
75bc73fc0188ef Richard Gong 2020-06-15 53 * @dcmf_version.dcmf1: Quartus dcmf1 version
75bc73fc0188ef Richard Gong 2020-06-15 54 * @dcmf_version.dcmf2: Quartus dcmf2 version
75bc73fc0188ef Richard Gong 2020-06-15 55 * @dcmf_version.dcmf3: Quartus dcmf3 version
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 56 * @dcmf_status.dcmf0: dcmf0 status
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 57 * @dcmf_status.dcmf1: dcmf1 status
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 58 * @dcmf_status.dcmf2: dcmf2 status
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 59 * @dcmf_status.dcmf3: dcmf3 status
4526ebbc77732b Richard Gong 2019-09-03 60 * @retry_counter: the current image's retry counter
75bc73fc0188ef Richard Gong 2020-06-15 61 * @max_retry: the preset max retry value
4526ebbc77732b Richard Gong 2019-09-03 62 */
4526ebbc77732b Richard Gong 2019-09-03 63 struct stratix10_rsu_priv {
4526ebbc77732b Richard Gong 2019-09-03 64 struct stratix10_svc_chan *chan;
4526ebbc77732b Richard Gong 2019-09-03 65 struct stratix10_svc_client client;
4526ebbc77732b Richard Gong 2019-09-03 66 struct completion completion;
4526ebbc77732b Richard Gong 2019-09-03 67 struct mutex lock;
4526ebbc77732b Richard Gong 2019-09-03 68 struct {
4526ebbc77732b Richard Gong 2019-09-03 69 unsigned long current_image;
4526ebbc77732b Richard Gong 2019-09-03 70 unsigned long fail_image;
4526ebbc77732b Richard Gong 2019-09-03 71 unsigned int version;
4526ebbc77732b Richard Gong 2019-09-03 72 unsigned int state;
4526ebbc77732b Richard Gong 2019-09-03 73 unsigned int error_details;
4526ebbc77732b Richard Gong 2019-09-03 74 unsigned int error_location;
4526ebbc77732b Richard Gong 2019-09-03 75 } status;
75bc73fc0188ef Richard Gong 2020-06-15 76
75bc73fc0188ef Richard Gong 2020-06-15 77 struct {
75bc73fc0188ef Richard Gong 2020-06-15 78 unsigned int dcmf0;
75bc73fc0188ef Richard Gong 2020-06-15 79 unsigned int dcmf1;
75bc73fc0188ef Richard Gong 2020-06-15 80 unsigned int dcmf2;
75bc73fc0188ef Richard Gong 2020-06-15 81 unsigned int dcmf3;
75bc73fc0188ef Richard Gong 2020-06-15 82 } dcmf_version;
75bc73fc0188ef Richard Gong 2020-06-15 83
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 84 struct {
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 85 unsigned int dcmf0;
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 86 unsigned int dcmf1;
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 87 unsigned int dcmf2;
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 88 unsigned int dcmf3;
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 89 } dcmf_status;
4a6c8c565db1d0 Kah Jing Lee 2022-07-11 90
4526ebbc77732b Richard Gong 2019-09-03 91 unsigned int retry_counter;
75bc73fc0188ef Richard Gong 2020-06-15 92 unsigned int max_retry;
4526ebbc77732b Richard Gong 2019-09-03 @93 };
4526ebbc77732b Richard Gong 2019-09-03 94
:::::: The code at line 93 was first introduced by commit
:::::: 4526ebbc77732bcae965ee374cf3e8d86436b2ad firmware: add Intel Stratix10 remote system update driver
:::::: TO: Richard Gong <richard.gong@xxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki