Re: [PATCH net-next v3 09/19] net: ravb: Split GTI computation and set operations
From: Sergey Shtylyov
Date: Sat Jan 06 2024 - 14:59:01 EST
On 1/5/24 11:23 AM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> ravb_set_gti() was computing the value of GTI based on the reference clock
> rate and then applied it to register. This was done on the driver's probe
> function. In order to implement runtime PM for all IP variants (as some IP
> variants switches to reset mode (and thus the registers content is lost)
> when module standby is configured through clock APIs) the GTI setup was
> split in 2 parts: one computing the value of the GTI register (done in the
> driver's probe function) and one applying the computed value to register
> (done in the driver's ndo_open API).
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> ---
>
> Changes in v3:
> - fixed typos in patch description
> - use u64 instead of uint64_t
Well, u64 in one place, u32 in another...
> - remove ravb_wait() for setting GCCR.LTI
[...]
MBR, Sergey