Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver

From: Andy Shevchenko
Date: Sat Jan 06 2024 - 10:57:54 EST


On Fri, Dec 29, 2023 at 11:24:38AM +0200, Petre Rodan wrote:
> Add SPI component of the driver.

> Tested with mprls0015pa0000sa in spi mode on BeagleBone Black on
> slightly patched 6.7.0-rc6 mainline.

> Tested with mprls0025pa in i2c mode on BeagleBone Black with togreg
> branch on
> git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> (tag: iio-for-6.8a)

I believe these paragraphs can be moved to the patch submission comments from
the commit message...

> Tested-by: Andreas Klinger <ak@xxxxxxxxxxxxx>
> Signed-off-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx>
> ---
> v2 -> v3 removed iio.h include line

...somewhere here.

...

> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/spi/spi.h>
> +#include <linux/stddef.h>

Basically here we need additionally these ones:

device.h
errno.h
types.h

(I haven't checked i2c counterpart for the similarities).

--
With Best Regards,
Andy Shevchenko