Re: [PATCH 4.14 00/20] 4.14.335-rc2 review

From: Naresh Kamboju
Date: Sat Jan 06 2024 - 04:48:51 EST


On Sat, 6 Jan 2024 at 14:10, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> This is the start of the stable review cycle for the 4.14.335 release.
> There are 20 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Mon, 08 Jan 2024 08:40:01 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

As Daniel reported on RC1 about this failure.
Following build failures noticed on 4.14.335-rc2

Arm64 with Clang 17:

-----8<-----
/builds/linux/net/8021q/vlan_core.c:332:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short')
to parameter of type 'const struct vlan_vi
d_info *' [-Wint-conversion]
332 | if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
| ^~~~~~~~~~~~~~~
/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
/builds/linux/net/8021q/vlan_core.c:344:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short')
to parameter of type 'const struct vlan_vi
d_info *' [-Wint-conversion]
344 | if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
| ^~~~~~~~~~~~~~~
/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
/builds/linux/net/8021q/vlan_core.c:366:39: error: incompatible
integer to pointer conversion passing '__be16' (aka 'unsigned short')
to parameter of type 'const struct vlan_vid_info *' [-Wint-conversion]
366 | if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
| ^~~~~~~~~~~~~~~
/builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument
to parameter 'vid_info' here
169 | const struct
vlan_vid_info *vid_info)
| ^
3 errors generated.
make[3]: *** [/builds/linux/scripts/Makefile.build:329:
net/8021q/vlan_core.o] Error 1
----->8-----

Bisection in this case points to:

commit f33474044777425b3578d4e8b22a003f034ae214
Author: Liu Jian <liujian56@xxxxxxxxxx>
Date: Sat Dec 16 15:52:18 2023 +0800

net: check vlan filter feature in vlan_vids_add_by_dev() and
vlan_vids_del_by_dev()

[ Upstream commit 01a564bab4876007ce35f312e16797dfe40e4823 ]

Reproducer:

tuxmake --runtime podman --target-arch arm64 --toolchain clang-17
--kconfig defconfig LD=ld.lld LLVM_IAS=0

Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>


Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx

- Naresh