Re: [PATCH v1 1/1] arm64: remove unnecessary ifdefs around is_compat_task()

From: kernel test robot
Date: Fri Jan 05 2024 - 23:30:30 EST


Hi Leonardo,

kernel test robot noticed the following build errors:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on linus/master v6.7-rc8 next-20240105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Leonardo-Bras/arm64-remove-unnecessary-ifdefs-around-is_compat_task/20240105-121957
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
patch link: https://lore.kernel.org/r/20240105041458.126602-3-leobras%40redhat.com
patch subject: [PATCH v1 1/1] arm64: remove unnecessary ifdefs around is_compat_task()
config: arm64-randconfig-001-20240105 (https://download.01.org/0day-ci/archive/20240106/202401061219.Y2LD7LTx-lkp@xxxxxxxxx/config)
compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project 7e186d366d6c7def0543acc255931f617e76dff0)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240106/202401061219.Y2LD7LTx-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401061219.Y2LD7LTx-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> arch/arm64/kernel/ptrace.c:2121:11: error: use of undeclared identifier 'user_aarch32_view'; did you mean 'user_aarch64_view'?
2121 | return &user_aarch32_view;
| ^~~~~~~~~~~~~~~~~
| user_aarch64_view
arch/arm64/kernel/ptrace.c:1591:38: note: 'user_aarch64_view' declared here
1591 | static const struct user_regset_view user_aarch64_view = {
| ^
>> arch/arm64/kernel/ptrace.c:2123:11: error: use of undeclared identifier 'user_aarch32_ptrace_view'
2123 | return &user_aarch32_ptrace_view;
| ^
2 errors generated.


vim +2121 arch/arm64/kernel/ptrace.c

478fcb2cdb2351 Will Deacon 2012-03-05 2111
478fcb2cdb2351 Will Deacon 2012-03-05 2112 const struct user_regset_view *task_user_regset_view(struct task_struct *task)
478fcb2cdb2351 Will Deacon 2012-03-05 2113 {
5d220ff9420f8b Catalin Marinas 2015-07-14 2114 /*
5d220ff9420f8b Catalin Marinas 2015-07-14 2115 * Core dumping of 32-bit tasks or compat ptrace requests must use the
5d220ff9420f8b Catalin Marinas 2015-07-14 2116 * user_aarch32_view compatible with arm32. Native ptrace requests on
5d220ff9420f8b Catalin Marinas 2015-07-14 2117 * 32-bit children use an extended user_aarch32_ptrace_view to allow
5d220ff9420f8b Catalin Marinas 2015-07-14 2118 * access to the TLS register.
5d220ff9420f8b Catalin Marinas 2015-07-14 2119 */
5d220ff9420f8b Catalin Marinas 2015-07-14 2120 if (is_compat_task())
478fcb2cdb2351 Will Deacon 2012-03-05 @2121 return &user_aarch32_view;
5d220ff9420f8b Catalin Marinas 2015-07-14 2122 else if (is_compat_thread(task_thread_info(task)))
5d220ff9420f8b Catalin Marinas 2015-07-14 @2123 return &user_aarch32_ptrace_view;
e802ab35101cdf Leonardo Bras 2024-01-05 2124
478fcb2cdb2351 Will Deacon 2012-03-05 2125 return &user_aarch64_view;
478fcb2cdb2351 Will Deacon 2012-03-05 2126 }
478fcb2cdb2351 Will Deacon 2012-03-05 2127

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki