Re: [PATCH] rxrpc: Fix skbuff cleanup of call's recvmsg_queue and rx_oos_queue

From: David Howells
Date: Fri Jan 05 2024 - 16:25:11 EST


David Howells <dhowells@xxxxxxxxxx> wrote:

> Fix rxrpc_cleanup_ring() to use rxrpc_purge_queue() rather than
> skb_queue_purge() so that the count of outstanding skbuffs is correctly
> updated when a failed call is cleaned up.
>
> Without this rmmod may hang waiting for rxrpc_n_rx_skbs to become zero.
>
> Reported-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> cc: linux-afs@xxxxxxxxxxxxxxxxxxx
> cc: netdev@xxxxxxxxxxxxxxx

Fixes: 5d7edbc9231e ("rxrpc: Get rid of the Rx ring")