Re: [PATCH v2] regulator: qcom_smd: Keep one rpm handle for all vregs

[Konrad Dybcio]

On 5.01.2024 17:31, Mark Brown wrote:
> On Wed, Jan 03, 2024 at 09:18:37PM +0100, Konrad Dybcio wrote:
> 
>> -	rpm = dev_get_drvdata(pdev->dev.parent);
>> -	if (!rpm) {
>> +	smd_vreg_rpm = dev_get_drvdata(pdev->dev.parent);
>> +	if (!smd_vreg_rpm) {
>>  		dev_err(&pdev->dev, "Unable to retrieve handle to rpm\n");
>>  		return -ENODEV;
>>  	}
> 
> It'd be slightly more robust to have a check here that we do get the
> same RPM back if the variable is already set, just on the off chance
> that something changes in some future system and we do end up with a
> second RPM somehow.

Knowing how improbable this is (currently RPM is responsible for almost all
power and some clock rails, including DDR), I'd say it's excessive, but if
you wish, I can add it.

Konrad